Move BandedMatrices+BlockArrays to BlockArray extension #195
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.13 #195 +/- ##
================================================
+ Coverage 88.37% 89.53% +1.15%
================================================
Files 11 11
Lines 1204 1108 -96
================================================
- Hits 1064 992 -72
+ Misses 140 116 -24 ☔ View full report in Codecov by Sentry. |
|
Let's create a release-0.13 branch, as this would simplify collecting all the changes. Edit: I've created one now. Would you mind changing the target branch for this PR? |
|
Done. But what else is going in release-0.13? |
|
There are some other minor changes that might be useful, like not exporting |
|
What's wrong with exporting them? |
|
It just makes the package more prone to breakages, as breaking changes upstream get translated to this package as well, which shouldn't be the case usually. Typically, one may bump the minor or patch version of a package to incorporate a breaking version of a dependency. |
Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2. - [Release notes](https://github.com/julia-actions/cache/releases) - [Commits](julia-actions/cache@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
ok I see your point |
* Don't export names not owned by the package (#203) * Move BandedMatrices+BlockArrays to BlockArray extension (#195) * Move some banded matrix stuff to BlockArrays extension * Update interfaceimpl.jl * Move over more code * tests pass * Update Project.toml * v0.13 * Update BlockBandedMatrices.jl * Update BlockBandedMatrices.jl * updates * Bump julia-actions/cache from 1 to 2 (#204) Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2. - [Release notes](https://github.com/julia-actions/cache/releases) - [Commits](julia-actions/cache@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * PseudoBlockMatrix -> BlockedMatrix * Update BlockSkylineMatrix.jl * Update BandedBlockBandedMatrix.jl * Move out banded code --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jishnu Bhattacharya <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.